khalidmammadov commented on a change in pull request #20625:
URL: https://github.com/apache/airflow/pull/20625#discussion_r777518038
##########
File path: airflow/providers/qubole/operators/qubole.py
##########
@@ -217,7 +217,7 @@ class QuboleOperator(BaseOperator):
'cluster_label',
)
- template_ext: Iterable[str] = ('.txt',)
+ template_ext: Sequence[str] = ('.txt',)
Review comment:
The reason for below set-tuple conversion is to remove any duplicates
and hence `set` with `union` operator was used prior to conversion. It's
similar to one in here:
https://github.com/apache/airflow/blob/84a4bcca293ac1c85a91dfc7f97938ff2fd9c564/airflow/providers/qubole/operators/qubole_check.py#L108-L110
Well, it also means that if we dont need dups then Set type would be more
appropriate
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]