khalidmammadov commented on a change in pull request #20625:
URL: https://github.com/apache/airflow/pull/20625#discussion_r777718335
##########
File path: airflow/providers/qubole/operators/qubole.py
##########
@@ -217,7 +217,7 @@ class QuboleOperator(BaseOperator):
'cluster_label',
)
- template_ext: Iterable[str] = ('.txt',)
+ template_ext: Sequence[str] = ('.txt',)
Review comment:
As a caution I will also need to change the type of values it
(template_fields) gets assigned to, which are mostly `tuple` and will become
all `set`. Also documentation needs to be amended as there were no much
emphasis on the type of these fields and list also were used:
https://airflow.apache.org/docs/apache-airflow/stable/concepts/operators.html#jinja-templating
This means we also need to notify users about this change.
Alternatively, we can leave them as is and let users to use list, tuple etc.
to provide simplicity of use and internally carry on removing duplicates as
they (dups) dont make any sense. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
