SamWheating commented on a change in pull request #20753:
URL: https://github.com/apache/airflow/pull/20753#discussion_r780840690
##########
File path: airflow/providers/cncf/kubernetes/CHANGELOG.rst
##########
@@ -25,18 +25,25 @@ Changelog
Breaking changes
~~~~~~~~~~~~~~~~
+* ``Parameter is_delete_operator_pod default is changed to True (#20575)``
* ``Simplify KubernetesPodOperator (#19572)``
-* ``Delete pods by default in KubernetesPodOperator (#20575)``
* ``Move pod_mutation_hook call from PodManager to KubernetesPodOperator
(#20596)``
* ``Rename ''PodLauncher'' to ''PodManager'' (#20576)``
-.. warning:: Many methods in ``KubernetesPodOperator`` and ``PodLauncher``
have been renamed.
- If you have subclassed ``KubernetesPodOperator`` will need to update your
subclass to reflect
- the new structure. Additionally ``PodStatus`` enum has been renamed to
``PodPhase``.
+Parameter is_delete_operator_pod has new default
+````````````````````````````````````````````````
+
+Previously, the default for param ``is_delete_operator_pod`` was ``False``,
which means that
+after a task runs, its pod is not deleted by the operator and remains on the
+cluster indefinitely. With this release, we change the default to ``True``.
Notes on changes KubernetesPodOperator and PodLauncher
``````````````````````````````````````````````````````
+.. warning:: Many methods in ``KubernetesPodOperator`` and ``PodLauncher``
have been renamed.
+ If you have subclassed ``KubernetesPodOperator`` will need to update your
subclass to reflect
Review comment:
```suggestion
If you have subclassed ``KubernetesPodOperator`` you will need to update
your subclass to reflect
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
