potiuk commented on a change in pull request #20843:
URL: https://github.com/apache/airflow/pull/20843#discussion_r783698559
##########
File path: tests/sensors/test_python.py
##########
@@ -85,7 +85,7 @@ def test_python_callable_arguments_are_templatized(self):
ds_templated = DEFAULT_DATE.date().isoformat()
# 2 calls: first: at start, second: before timeout
- assert 2 == len(recorded_calls)
+ assert 1 <= len(recorded_calls)
Review comment:
It' sensor and number of calls depends on how fast the whole system is
at all. We know tht the first call happens for sure, and most of the time the
second too. The assert is actually correct IMHO ("expect at least 1 call"). We
only check the first call anyway (and this is the gist of it as we really want
to see if JINJA template works in the sensor call).
If you think on how to fix it better I am al ears :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
