potiuk commented on a change in pull request #20843:
URL: https://github.com/apache/airflow/pull/20843#discussion_r783700863
##########
File path: tests/sensors/test_python.py
##########
@@ -85,7 +85,7 @@ def test_python_callable_arguments_are_templatized(self):
ds_templated = DEFAULT_DATE.date().isoformat()
# 2 calls: first: at start, second: before timeout
- assert 2 == len(recorded_calls)
+ assert 1 <= len(recorded_calls)
Review comment:
The thing here is that his is the "timing" tests and we test it with
"run" method and expect timeout.
In perfect world, we could likely use freezegun and simulate the exact time
passing, but IMHO it is totally not worth it if we can 100% fix it with this
one character change. Trading test simplicity with perfectness.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
