Bowrna commented on pull request #20848:
URL: https://github.com/apache/airflow/pull/20848#issuecomment-1013101871
I am struck at one point in the PR @potiuk I have imported the list of
static checks that can be run. Now how do you think we can add the option in
click?
Do you want to add something like below?
```
@click.command()
@click.option('--type',
type=click.Choice(PRE_COMMITS_LIST, case_sensitive=False))
def static_check(type):
click.echo(type)
```
if we do this way then we may need to run the test like
```
Breeze2 static-check --type mypy
```
Something like above. This will be unlike the original breeze where you can
send,
```
./breeze static-check mypy
```
Also in current breeze, we support the commands like `./breeze static-check
all -- --from-ref HEAD^ --to-ref HEAD`
I think these are all the arguments that are supported in pre-commit. Do we
have to add all the pre-commit supported args as option in click?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
