xurror commented on pull request #20848: URL: https://github.com/apache/airflow/pull/20848#issuecomment-1014041714
> ``` Breeze2 static-check --type mypy ``` I think it will be better to do it like this. I think it will also look cleaner at the code level so we won't need to have multiple click commands. It would also be nice to also have the shorthand `-t` so the command is a bit shorter to type. > Also in current breeze, we support the commands like ./breeze static-check all -- --from-ref HEAD^ --to-ref HEAD I think these are all the arguments that are supported in pre-commit. Do we have to add all the pre-commit supported args as option in click? In my opinion, it will suffice to cover the most necessary ones for a start just so you can move forward and avoid running out of time. We can then come back to make further improvements later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
