o-nikolas commented on a change in pull request #20858:
URL: https://github.com/apache/airflow/pull/20858#discussion_r785076651
##########
File path: airflow/providers/amazon/aws/hooks/base_aws.py
##########
@@ -199,8 +199,6 @@ def _read_credentials_from_connection(self) ->
Tuple[Optional[str], Optional[str
self.extra_config.get("profile"),
)
self.log.info("Credentials retrieved from
extra_config['s3_config_file']")
- else:
- self.log.info("No credentials retrieved from Connection")
Review comment:
Hmm, interesting. The problem with this log line is that it's one of the
worst offenders for log spam, since it sits in an else that's guaranteed to run
even if you're not trying to use a connection for credentials at all (see the
example screenshot I've attached in the conversation tab). Which as far as
negative case logging goes, isn't that useful IMHO. This log line also adds no
additional runtime context (it logs no runtime data that's useful for
debugging) and it can simply be inferred if you don't see any of the other log
lines from above.
However, if all that is still not convincing, then perhaps we can agree to
add it back, but at debug level?
Let me know what you think!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
