potiuk commented on a change in pull request #20848:
URL: https://github.com/apache/airflow/pull/20848#discussion_r790345989
##########
File path: dev/breeze/src/airflow_breeze/breeze.py
##########
@@ -276,6 +281,22 @@ def change_config(python, backend, cheatsheet, asciiart):
console.print(f'[blue]Backend cached_value {backend}')
+@option_verbose
[email protected](name="static-check")
[email protected]('-t', '--type', type=click.Choice(PRE_COMMIT_LIST),
multiple=True)
+def static_check(verbose: bool, type: Tuple[str]):
Review comment:
I am tempted to add few more options here, some that make it a bit
easier to use in common cases:
* `--all-files` -> should also add `--all-files` for the pre-commit command
* `--last-commit` -> this one I found I use quite often and it should add
those params: `--from-ref` `HEAD^` `--to-ref` `HEAD`
* `--show-diff-on-failure` -> this one is useful to show what has been
changed (also passed as is).
* `--verbose`` -> verbose run option
Those should be auto-completeable as they should be used quite often. But
also we should be able to add "unknown" parameters (see below).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
