potiuk commented on a change in pull request #20848:
URL: https://github.com/apache/airflow/pull/20848#discussion_r790856129
##########
File path: dev/breeze/src/airflow_breeze/breeze.py
##########
@@ -276,6 +281,22 @@ def change_config(python, backend, cheatsheet, asciiart):
console.print(f'[blue]Backend cached_value {backend}')
+@option_verbose
[email protected](name="static-check")
[email protected]('-t', '--type', type=click.Choice(PRE_COMMIT_LIST),
multiple=True)
+def static_check(verbose: bool, type: Tuple[str]):
+ if check_package_installed('pre_commit'):
+ command_to_execute = ['pre-commit', 'run']
+ for single_check in type:
+ command_to_execute.append(single_check)
+ command_to_execute.append(EXTRA_STATIC_CHECK_OPTIONS)
+ output = run_command(
Review comment:
Good point. I think it won't work that nicely as I think click does not
have "file" *options* (they have file *arguments*). And
`ignore_unknown_options` will allow us to pass `--file` transparently. And
autocomplete works in the way that when you start typing file name I think it
will auto-complete the files available.
But it might be good indeed to have a `--file` as option for autocomplete.
Something to test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
