mik-laj commented on issue #20254:
URL: https://github.com/apache/airflow/issues/20254#issuecomment-1019669958


   > The bash script is needed because _script_init.sh is called to set the 
"AIRFLOW_CI_IMAGE` variable - this variable is then used internally by some 
tests to determine which image should be tested.
   
   This is needed for some tests, but for the 
`test_examples_of_prod_image_building.py` test we don't need any environment 
variable. 
   
   If I remember correctly some tests rely on a variable called `AIRFLOW_IMAGE` 
and we will have to set it, but this is a different kind of test. They are in 
one directory but in a different file.
   
https://github.com/apache/airflow/blob/44df1420582b358594c8d7344865811cff02956c/scripts/ci/images/ci_run_docker_compose_quick_start_test.sh#L22-L23
   
   > We already have breeze virtualenv 
   
   If breeze has a virtual environment, we should use it.
   
   From what I can see, file `scripts/ci/images/ci_run_prod_image_test.sh` 
should be removed as it is no longer used, because now we have all the tests in 
Python. Here is related PR: https://github.com/apache/airflow/pull/19819/files
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to