Bowrna commented on pull request #21145: URL: https://github.com/apache/airflow/pull/21145#issuecomment-1023245481
> > @potiuk i can see several env variables in scripts/ci/libraries/_initialization.sh. > > We definitely should not try to set all of those. They are needed by different parts of "old breeze". The variables that we should pass are exactly those which are "generated" in the "dc_ci" script - just take a look what you have in `./build/dc_ci` and those are the only environment variables that are really needed to run the CI. Another place (we have a few of those) that you can reconcile are in `scripts/ci/docker-compose/_docker.env` and the same variables are repeated in `scripts/ci/docker-compose/base.yaml` - maybe there are some slight differences we will have to reconcile. > > BTW. The reason why we have it in many places is that there are some difference in how "docker-compose 1" and "docker-compose 2" work. This will likely go away soon (Docker-compose 2 has been introduced recently and I think we will soon be able to deprecate docker-compose 1) at which time we will be able to remove one of those lists. > > I think (can't remember) I have a pre-commit that keeps those in-check - but maybe I have not done that, so better to check and reconcile it now. > > Regardless-having yet another list of the variables in python in "global_constants" that will be the "source of truth" would be great. @potiuk ok, I will check the vars in dc_ci script. Also you have mentioned about reconciling vars in `scripts/ci/docker-compose/_docker.env` and `scripts/ci/docker-compose/base.yaml`. I will check that part to understand more about it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
