Bowrna commented on pull request #21145:
URL: https://github.com/apache/airflow/pull/21145#issuecomment-1024939890


   > "trap" makes sure that no matter if we nicely exist or Ctrl-C, or fail, 
those files are automatically deleted. The SKIP_CACHE_DELETION variable was 
just an escape hatch to not delete the files while debugging. I think we do not 
need it any more (and we can always coment out the code that deletes it when 
debugging).
   > 
   > In Python this "trap" functionality (not the same but good enough) can be 
achieved by https://docs.python.org/3/library/atexit.html. And I think this is 
the right way.
   
   Oh wow :) I am learning a lot of new things from this one PR. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to