Bowrna commented on pull request #21145: URL: https://github.com/apache/airflow/pull/21145#issuecomment-1025707546
Some useful docs in semver library. Version equality means for semver, that major, minor, patch, and prerelease parts are equal in both versions you compare. The build part is ignored https://github.com/python-semver/python-semver/blob/master/docs/usage/determine-version-equality.rst We can replace the prerelease part with empty string and do the comparison. https://github.com/python-semver/python-semver/blob/master/docs/usage/replace-parts-of-a-version.rst > However one of our users who run ./breeze in Azure Code QL ( which is Azure's CI system) got error that the version could not be parsed, because in Azure Code QL, they MODIFIED the version of docker they have installed and the version returned was something like: > > ``` > docker version --format '{{.Client.Version}}' > 20.10.7+azure > ``` Here the `+azure` would indicate the build part. So I think we don't need to remove it explicitely like how it's done using sed in bash. We can simply pass that to semver and it will work fine. Please share your views on this @potiuk -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
