Bowrna commented on pull request #21145:
URL: https://github.com/apache/airflow/pull/21145#issuecomment-1027121665


   @potiuk could you explain to me this part? I can understand that we check if 
the files in the list of `FILES_FOR_REBUILD_CHECK` are modified. we use md5sum 
to determine that. we persist the old md5sum calculated in build cache and if 
it varies from the recent file, we assume that file is modified and do build 
the local image. But why do we have to calculate them for only specific files 
in that list? 
   
   Even with docker buildx coming, we will still use this to determine if we 
have to build the image or not. Am i right ?
   
   
https://github.com/apache/airflow/blob/2f4a3d4d4008a95fc36971802c514fef68e8a5d4/scripts/ci/libraries/_md5sum.sh#L98-L110


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to