malthe commented on a change in pull request #21213:
URL: https://github.com/apache/airflow/pull/21213#discussion_r796011533
##########
File path: tests/jobs/test_triggerer_job.py
##########
@@ -448,7 +452,7 @@ def test_invalid_trigger(session, dag_maker):
job.load_triggers()
# Make sure it turned up in the failed queue
- assert list(job.runner.failed_triggers) == [1]
+ assert len(job.runner.failed_triggers) == 1
Review comment:
Yeah, the before test was stricter. But now failed triggers are a
2-tuple so if we test the first component, do we then need to test the other
one as well etc – to my mind, these tests are just heuristics trying to help us
prevent bugs, but they can't be exhaustive.
But I can make it as strict as before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
