dstandish commented on a change in pull request #19505: URL: https://github.com/apache/airflow/pull/19505#discussion_r802975969
########## File path: airflow/utils/parameters.py ########## @@ -0,0 +1,37 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +import inspect +from collections import namedtuple + +InspectSignatureResult = namedtuple('InspectSignatureResult', ['bound_arguments', 'has_kwargs']) + + +def inspect_function_arguments(function) -> InspectSignatureResult: + """ + Returns the list of variables names of a function and if it + accepts keyword arguments. + + :param function: The function to inspect + :rtype: InspectSignatureResult + """ + parameters = inspect.signature(function).parameters + bound_arguments = [ + name for name, p in parameters.items() if p.kind not in (p.VAR_POSITIONAL, p.VAR_KEYWORD) + ] + has_kwargs = any(p.kind == p.VAR_KEYWORD for p in parameters.values()) + return InspectSignatureResult(list(bound_arguments), has_kwargs) Review comment: short answer no. but there are around 10 usages of inspect.signature in airflow repo. and this helper function i think is convenient and those other usages would probably benefit from it. BUT your point is taken and we could inline it here and then (possibly) make it a util and refactor usages in a later PR (where the justification for such a util would be more readily apparent). shall i inline for now? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
