potiuk commented on pull request #21145: URL: https://github.com/apache/airflow/pull/21145#issuecomment-1035006093
> @potiuk Am I right in understanding that I have to show message/instruction asking user to do build part? Or do i have to execute the `build-ci-image`/`build-prod-image` command? Execute the command. The flow should be like that: 1) User runs ./breeze without `--force-build`: * if the image is "fresh" - just start breeze shell * if the image is "not-fresh" - display the warning and give the user 4 seconds to answer "y/n/q" question whether to build image 2) User runs ./breeze with `--force-build`: * no matter what the "build is started" There is just one thing to watch out: when we start the build in either of the scenarios above, we start an addtional check. We check if the user is rebased to latest "main" (there is a piece of code in the current breeze already). If the user is not rebased, then we print the warning "This will take a lot of time, we think you should rebase first, but if you really, really want - you can do it". Here "y/n/q" question again - but this time wihout "timeout". The users should deliberately press "y" if they try to rebuild, but they are not rebased. This might lead to really long build times so it should be really confirmed by the user. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
