potiuk commented on pull request #21145:
URL: https://github.com/apache/airflow/pull/21145#issuecomment-1042811453


   This actually looks great @Bowrna ! I had finally time to take a closer look 
and try it out and it "ALMOST" worked from the first try - I added the (rather 
small) fixup to the problem you struggled with when passing the env variables - 
mostly to show you quickly how this could be done better. I added all the 
explanation so that you can see my reasoning and why this way might be better 
:). 
   
   I will also add another small fixup with example test in a moment.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to