mhenc commented on a change in pull request #21301:
URL: https://github.com/apache/airflow/pull/21301#discussion_r808776122
##########
File path: airflow/callbacks/callback_requests.py
##########
@@ -55,7 +53,7 @@ class TaskCallbackRequest(CallbackRequest):
def __init__(
self,
full_filepath: str,
- simple_task_instance: SimpleTaskInstance,
+ simple_task_instance, #: SimpleTaskInstance, Avoid circular import
Review comment:
unfortunatelly this causes circular dependency
We could either remove the typing there or move the `callback_request.py` to
subfolder `airflow/callbacks/model/callback_requests.py`
WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
