mhenc commented on a change in pull request #21301:
URL: https://github.com/apache/airflow/pull/21301#discussion_r809804200
##########
File path: airflow/executors/base_executor.py
##########
@@ -310,3 +313,14 @@ def debug_dump(self):
len(self.event_buffer),
"\n\t".join(map(repr, self.event_buffer.items())),
)
+
+ def send_callback_to_execute(self, request: CallbackRequest) -> None:
+ """Sends callback for execution.
+
+ Provides a default implementation which sends the callback to
DagProcessor.
+
+ :param request: Callback request to be executed.
+ """
+ if not self.callbacks_sink:
+ raise ValueError("Callback sink is not ready.")
+ self.callbacks_sink.send_callback_to_execute(request)
Review comment:
Done
##########
File path: airflow/callbacks/callback_requests.py
##########
@@ -55,7 +53,7 @@ class TaskCallbackRequest(CallbackRequest):
def __init__(
self,
full_filepath: str,
- simple_task_instance: SimpleTaskInstance,
+ simple_task_instance, #: SimpleTaskInstance, Avoid circular import
Review comment:
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
