ashb commented on a change in pull request #19857:
URL: https://github.com/apache/airflow/pull/19857#discussion_r810015933
##########
File path: airflow/cli/commands/connection_command.py
##########
@@ -82,25 +83,35 @@ def connections_list(args):
)
+def _connection_to_dict(conn: Connection) -> dict:
+ return dict(
+ conn_type=conn.conn_type,
+ description=conn.description,
+ login=conn.login,
+ password=conn.password,
+ host=conn.host,
+ port=conn.port,
+ schema=conn.schema,
+ extra=conn.extra,
Review comment:
What about dejson? Wouldn't this likely result in the extra field being
a string containing a JSON dict?, i.e. `"extra": "{\"extra_key\": \"value\"}"`
(I'm not sure there's a ready solution to this, as it's _possible_ the extra
isn't JSON
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
