ashb commented on a change in pull request #19857:
URL: https://github.com/apache/airflow/pull/19857#discussion_r810233976
##########
File path: airflow/cli/commands/connection_command.py
##########
@@ -82,25 +83,35 @@ def connections_list(args):
)
+def _connection_to_dict(conn: Connection) -> dict:
+ return dict(
+ conn_type=conn.conn_type,
+ description=conn.description,
+ login=conn.login,
+ password=conn.password,
+ host=conn.host,
+ port=conn.port,
+ schema=conn.schema,
+ extra=conn.extra,
Review comment:
> We just can't serialize in this way by default because there is no
guarantee that extra will be json
Yeah, that's sort of what I was getting it.
I think we should work out a deprecation plan for storing anything but json
in extra.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
