hsrocks commented on pull request #21073:
URL: https://github.com/apache/airflow/pull/21073#issuecomment-1044777473


   > I would be curious to learn how these hooks and operators are related to 
the already existing logic available in Systems Manager Backend in Amazon 
Provider package: 
`airflow.providers.amazon.aws.secrets.systems_manager.SystemsManagerParameterStoreBackend`
   > 
   > I wonder if we should leverage these hooks in the Backend class now? it 
seems like some code is repeated in these 2?
   > 
   > CC: @potiuk @o-nikolas
   
   Thanks for review @dbarrundiag !! While I am not sure on the reason but I 
think they want to ensure segregation between hooks/operators and secrets 
module. But if thats not true the we can use secrets_manager hook in this class 
as well: 
airflow.providers.amazon.aws.secrets.secrets_manager.SecretsManagerBackend 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to