dstandish commented on a change in pull request #19857:
URL: https://github.com/apache/airflow/pull/19857#discussion_r810249514
##########
File path: airflow/secrets/environment_variables.py
##########
@@ -30,8 +31,21 @@ class EnvironmentVariablesBackend(BaseSecretsBackend):
"""Retrieves Connection object and Variable from environment variable."""
def get_conn_uri(self, conn_id: str) -> Optional[str]:
- environment_uri = os.environ.get(CONN_ENV_PREFIX + conn_id.upper())
- return environment_uri
+ """
+ Return URI representation of Connection conn_id
+ :param conn_id: the connection id
+ :return: deserialized Connection
+ """
+ warnings.warn(
Review comment:
if `get_connection` is doing the calling, it will find `get_conn_value`
and it will not call this method. so there should be no double warning.
but we can't just remove this method right? we have to deprecate it. so i
think this warning needs to stay no?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
