dstandish commented on a change in pull request #19857:
URL: https://github.com/apache/airflow/pull/19857#discussion_r810320373
##########
File path: airflow/secrets/base_secrets.py
##########
@@ -26,8 +26,15 @@
class BaseSecretsBackend(ABC):
"""Abstract base class to retrieve Connection object given a conn_id or
Variable given a key"""
- def __init__(self, **kwargs):
- pass
+ def __init__(self, connection_serialization_format: Optional[str] = None,
**kwargs):
+ from airflow.configuration import conf # must be local to avoid
circular import
Review comment:
do you think there is anything we could do about it?
i suppose it would be possible to have a `bootstrap_configuration.py`, or
`secrets_configuration.py`, where we parse the secrets backend config and
initialize secrets backend before doing everything in configuration.py. wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
