uranusjr commented on a change in pull request #21699:
URL: https://github.com/apache/airflow/pull/21699#discussion_r810954115
##########
File path: airflow/hooks/dbapi.py
##########
@@ -345,11 +347,13 @@ def bulk_load(self, table, tmp_file):
"""
raise NotImplementedError()
+ # TODO: Merge this implementation back to DbApiHook when dropping
+ # support for Airflow 2.2.
Review comment:
This should be added to *OracleHook*’s `test_connection` instead.
##########
File path: airflow/providers/oracle/hooks/oracle.py
##########
@@ -52,6 +52,8 @@ class OracleHook(DbApiHook):
supports_autocommit = True
+ _test_connection_sql = "select 1 from dual"
Review comment:
Unfortunately we can’t do this yet because the provider still needs to
support Airflow 2.2 and lower. The full `test_connection` function still needs
to exist for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
