turbaszek commented on a change in pull request #20882: URL: https://github.com/apache/airflow/pull/20882#discussion_r812167485
########## File path: airflow/providers/google/cloud/example_dags/example_looker.py ########## @@ -0,0 +1,63 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +""" +Example Airflow DAG that show how to use various Looker +operators to submit PDT materialization job and manage it. +""" + +from datetime import datetime + +from airflow import models +from airflow.providers.google.cloud.operators.looker import LookerStartPdtBuildOperator +from airflow.providers.google.cloud.sensors.looker import LookerCheckPdtBuildSensor + +with models.DAG( + dag_id='example_gcp_looker', + schedule_interval='@once', + start_date=datetime(2021, 1, 1), + catchup=False, +) as dag: + # [START cloud_looker_async_start_pdt_sensor] + start_pdt_task_async = LookerStartPdtBuildOperator( + task_id='looker_pdt_task_async', Review comment: ```suggestion task_id='start_pdt_task_async', ``` That's not necessary but a good practice is to keep `task_id` aligned with the parameter name. It's more consistent 👍 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
