mik-laj commented on a change in pull request #20882: URL: https://github.com/apache/airflow/pull/20882#discussion_r813974499
########## File path: airflow/providers/google/cloud/operators/looker.py ########## @@ -0,0 +1,102 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# +"""This module contains Google Cloud Looker operators.""" + +from typing import TYPE_CHECKING, Dict, Optional + +from airflow.models import BaseOperator +from airflow.providers.google.cloud.hooks.looker import LookerHook + +if TYPE_CHECKING: + from airflow.utils.context import Context + + +class LookerStartPdtBuildOperator(BaseOperator): + """ + Submits a PDT materialization job to Looker. + + :param looker_conn_id: Required. The connection ID to use connecting to Looker. + :param model: Required. The model of the PDT to start building. + :param view: Required. The view of the PDT to start building. + :param query_params: Optional. Additional materialization parameters. + :param asynchronous: Optional. Flag indicating whether to wait for the job + to finish or return immediately. + This is useful for submitting long running jobs and + waiting on them asynchronously using the LookerCheckPdtBuildSensor + :param cancel_on_kill: Optional. Flag which indicates whether cancel the + hook's job or not, when on_kill is called. + :param wait_time: Optional. Number of seconds between checks for job to be + ready. Used only if ``asynchronous`` is False. + :param wait_timeout: Optional. How many seconds wait for job to be ready. + Used only if ``asynchronous`` is False. + """ + + def __init__( + self, + looker_conn_id: str, + model: str, + view: str, + query_params: Optional[Dict] = None, + asynchronous: bool = False, + cancel_on_kill: bool = True, + wait_time: int = 10, + wait_timeout: Optional[int] = None, + **kwargs, + ) -> None: + super().__init__(**kwargs) + self.model = model + self.view = view + self.query_params = query_params + self.looker_conn_id = looker_conn_id + self.asynchronous = asynchronous + self.cancel_on_kill = cancel_on_kill + self.wait_time = wait_time + self.wait_timeout = wait_timeout + self.hook: Optional[LookerHook] = None + self.materialization_id: Optional[str] = None + + def execute(self, context: "Context") -> str: + + self.hook = LookerHook(looker_conn_id=self.looker_conn_id) + + resp = self.hook.start_pdt_build( + model=self.model, + view=self.view, + query_params=self.query_params, + ) + + self.materialization_id = resp.materialization_id + + # materialization_id shouldn't be None, ensure mypy about that + assert self.materialization_id is not None Review comment: Please cont use asserts outside tests https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#don-t-use-asserts-outside-tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
