ferruzzi commented on a change in pull request #21673:
URL: https://github.com/apache/airflow/pull/21673#discussion_r813427675
##########
File path: tests/providers/amazon/aws/operators/test_sagemaker_model.py
##########
@@ -63,3 +66,17 @@ def test_execute_with_failure(self, mock_model, mock_client):
mock_model.return_value = {'ModelArn': 'testarn', 'ResponseMetadata':
{'HTTPStatusCode': 404}}
with pytest.raises(AirflowException):
self.sagemaker.execute(None)
+
+
+class TestSageMakerDeleteModelOperator(unittest.TestCase):
+ def setUp(self):
+ self.sagemaker = SageMakerDeleteModelOperator(
+ task_id='test_sagemaker_operator',
aws_conn_id='sagemaker_test_id', model_name='test'
+ )
+
+ @mock.patch.object(SageMakerHook, 'get_conn')
+ @mock.patch.object(SageMakerHook, 'delete_model')
+ def test_model_delete(self, mock_model, mock_client):
Review comment:
Nitpick, take it or leave it, but I'd rename `mock_model` to
`mock_delete_model` for clarity, but I suppose that's personal preference.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
