uranusjr commented on a change in pull request #21731:
URL: https://github.com/apache/airflow/pull/21731#discussion_r816577571
##########
File path: airflow/callbacks/callback_requests.py
##########
@@ -34,13 +35,21 @@ def __init__(self, full_filepath: str, msg: Optional[str] =
None):
self.msg = msg
def __eq__(self, other):
- if isinstance(other, CallbackRequest):
+ if isinstance(other, self.__class__):
return self.__dict__ == other.__dict__
return False
Review comment:
This should be changed to `return NotImplemented`. Not strictly
necessary for Airflow’s particular use case, but this is a best practice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
