uranusjr commented on a change in pull request #21731:
URL: https://github.com/apache/airflow/pull/21731#discussion_r816582767
##########
File path: airflow/jobs/scheduler_job.py
##########
@@ -858,7 +865,7 @@ def _do_scheduling(self, session) -> int:
self.log.error("DAG '%s' not found in serialized_dag
table", dag_run.dag_id)
continue
- self._send_dag_callbacks_to_processor(dag, callback_to_run)
+ callbacks_to_send.append((dag, callback_to_run))
Review comment:
Hmm, this may change the behaviour in some cases. Judging from the
`expunge_all()` call below, I suspect the callbacks are allowed to update the
database before the critical section below. Moving the callbacks to after the
section means they no longer have this ability.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
