pingzh commented on a change in pull request #21877:
URL: https://github.com/apache/airflow/pull/21877#discussion_r832502441
##########
File path: airflow/models/taskinstance.py
##########
@@ -1410,18 +1410,7 @@ def _execute_task_with_callbacks(self, context,
test_mode=False):
"""Prepare Task for Execution"""
from airflow.models.renderedtifields import RenderedTaskInstanceFields
- parent_pid = os.getpid()
Review comment:
> BTW. I think we should not remove forking. If you want to remove it ,
then this should be a separate PR where you explain why. Forking is shaving
multiple seconds when startting the task sometimes because it does not have to
launch the interpreter. I'd even say that we won't remove forking because of
that. There shuld be very good reason why we would like to remove it and some
justification on how it impacts the task start time.
updated the pr description to reflect the reason for removing `fork` in the
`TaskRunner`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
