pingzh commented on a change in pull request #21877:
URL: https://github.com/apache/airflow/pull/21877#discussion_r834544452
##########
File path: airflow/jobs/local_task_job.py
##########
@@ -104,11 +104,6 @@ def signal_handler(signum, frame):
try:
self.task_runner.start()
- # Unmap the task _after_ it has forked/execed. (This is a bit of a
kludge, but if we unmap before
Review comment:
@potiuk i have updated the pr description to reflect why the `fork`
needs to be removed.
1. `airflow tasks run --local` process no longer parses dag files. So
forking this process won't let the `airflow tasks run --raw` get the parsed dag
object, unless we add additional logic to parse dag file in the fork.
2. The TaskRunner only forks the `airflow tasks run --local` process when
there is no run_as_user.
I agree that fork can speed up `airflow tasks run --raw` process. I can add
it back in this PR so that we can focus mainly on the main topic of AIP 45
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
