uranusjr commented on pull request #22475: URL: https://github.com/apache/airflow/pull/22475#issuecomment-1077473599
I’m still skeptical, there’s no information I could find on what happens if an exception is bubbled uncaught in a forked child, but I’d be surprised if `except BaseException` is needed but nobody is telling people to do it. The difference between catching BaseException or not is not whether `os._exit()` will be called, but whether additional cleanups _not_ done by `os._exit()` will happen if we leave BaseException uncaught. I suspect that’s not the case, but do not have proof for either case. I guess technically it does no harm to always catch BaseException and do `os._exit()` manually (instead of letting the BaseException bubble and the interpreter to quit naturally), so if you feel strongly about this I am not going to stop you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
