potiuk commented on pull request #22475:
URL: https://github.com/apache/airflow/pull/22475#issuecomment-1077542397
Actually the discussion above made me aware that we should add a bit more
cases:
* when SystemExit is called - we should take return_code from it
* whan any of the BaseExceptions (including SystemExit) is caught we should
avoid logging them. There is no point in doing it (same as usual when you catch
Exception)
However I still firmly believe we need to catch the BaseException and run
sys._exit() outside of the try/except/finally clause in case of fork,
otherwiuse cleanup handlers, flushing other buffers than those we explicitly do
in finally (sentry + logging).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
