jedcunningham commented on code in PR #22676:
URL: https://github.com/apache/airflow/pull/22676#discussion_r842161743
##########
chart/values.schema.json:
##########
@@ -799,8 +799,8 @@
"x-docsSection": "Airflow",
"default": null,
"examples": [
- "- secretRef:\n name: '{{ .Release.Name
}}-airflow-connections'",
- "- configMapRef:\n name: '{{ .Release.Name
}}-airflow-variables'"
+ "- secretRef:\n name: '{{ include 'airflow.fullname' .
}}-airflow-connections'",
Review Comment:
Even though it's an example, the quoting here seems like it'd be wrong.
Maybe this?
```suggestion
"- secretRef:\n name: \"{{ include 'airflow.fullname' .
}}-airflow-connections\"",
```
##########
docs/helm-chart/production-guide.rst:
##########
@@ -452,17 +452,17 @@ Here is the full list of secrets that can be disabled and
replaced by ``_CMD`` a
+-------------------------------------------------------+------------------------------------------+--------------------------------------------------+
| Default secret name if secret name not specified | Use a different
Kubernetes Secret | Airflow Environment Variable |
+=======================================================+==========================================+==================================================+
-| ``<RELEASE_NAME>-airflow-metadata`` |
``.Values.data.metadataSecretName`` | | ``AIRFLOW_CONN_AIRFLOW_DB``
|
+| ``<RELEASE_NAME>-metadata`` |
``.Values.data.metadataSecretName`` | | ``AIRFLOW_CONN_AIRFLOW_DB``
|
| |
| | ``AIRFLOW__CORE__SQL_ALCHEMY_CONN`` |
+-------------------------------------------------------+------------------------------------------+--------------------------------------------------+
| ``<RELEASE_NAME>-fernet-key`` |
``.Values.fernetKeySecretName`` | ``AIRFLOW__CORE__FERNET_KEY``
|
+-------------------------------------------------------+------------------------------------------+--------------------------------------------------+
| ``<RELEASE_NAME>-webserver-secret-key`` |
``.Values.webserverSecretKeySecretName`` | ``AIRFLOW__WEBSERVER__SECRET_KEY``
|
+-------------------------------------------------------+------------------------------------------+--------------------------------------------------+
-| ``<RELEASE_NAME>-airflow-result-backend`` |
``.Values.data.resultBackendSecretName`` | |
``AIRFLOW__CELERY__CELERY_RESULT_BACKEND`` |
+| ``<RELEASE_NAME>-result-backend`` |
``.Values.data.resultBackendSecretName`` | |
``AIRFLOW__CELERY__CELERY_RESULT_BACKEND`` |
| |
| | ``AIRFLOW__CELERY__RESULT_BACKEND`` |
+-------------------------------------------------------+------------------------------------------+--------------------------------------------------+
-| ``<RELEASE_NAME>-airflow-brokerUrl`` |
``.Values.data.brokerUrlSecretName`` | ``AIRFLOW__CELERY__BROKER_URL``
|
+| ``<RELEASE_NAME>-brokerUrl`` |
``.Values.data.brokerUrlSecretName`` | ``AIRFLOW__CELERY__BROKER_URL``
|
Review Comment:
```suggestion
| ``<RELEASE_NAME>-brokerUrl`` |
``.Values.data.brokerUrlSecretName`` | ``AIRFLOW__CELERY__BROKER_URL``
|
```
##########
docs/helm-chart/production-guide.rst:
##########
@@ -452,17 +452,17 @@ Here is the full list of secrets that can be disabled and
replaced by ``_CMD`` a
+-------------------------------------------------------+------------------------------------------+--------------------------------------------------+
| Default secret name if secret name not specified | Use a different
Kubernetes Secret | Airflow Environment Variable |
+=======================================================+==========================================+==================================================+
-| ``<RELEASE_NAME>-airflow-metadata`` |
``.Values.data.metadataSecretName`` | | ``AIRFLOW_CONN_AIRFLOW_DB``
|
+| ``<RELEASE_NAME>-metadata`` |
``.Values.data.metadataSecretName`` | | ``AIRFLOW_CONN_AIRFLOW_DB``
|
Review Comment:
```suggestion
| ``<RELEASE_NAME>-metadata`` |
``.Values.data.metadataSecretName`` | | ``AIRFLOW_CONN_AIRFLOW_DB``
|
```
Think I got the right number of spaces :)
##########
docs/helm-chart/production-guide.rst:
##########
@@ -452,17 +452,17 @@ Here is the full list of secrets that can be disabled and
replaced by ``_CMD`` a
+-------------------------------------------------------+------------------------------------------+--------------------------------------------------+
| Default secret name if secret name not specified | Use a different
Kubernetes Secret | Airflow Environment Variable |
+=======================================================+==========================================+==================================================+
-| ``<RELEASE_NAME>-airflow-metadata`` |
``.Values.data.metadataSecretName`` | | ``AIRFLOW_CONN_AIRFLOW_DB``
|
+| ``<RELEASE_NAME>-metadata`` |
``.Values.data.metadataSecretName`` | | ``AIRFLOW_CONN_AIRFLOW_DB``
|
| |
| | ``AIRFLOW__CORE__SQL_ALCHEMY_CONN`` |
+-------------------------------------------------------+------------------------------------------+--------------------------------------------------+
| ``<RELEASE_NAME>-fernet-key`` |
``.Values.fernetKeySecretName`` | ``AIRFLOW__CORE__FERNET_KEY``
|
+-------------------------------------------------------+------------------------------------------+--------------------------------------------------+
| ``<RELEASE_NAME>-webserver-secret-key`` |
``.Values.webserverSecretKeySecretName`` | ``AIRFLOW__WEBSERVER__SECRET_KEY``
|
+-------------------------------------------------------+------------------------------------------+--------------------------------------------------+
-| ``<RELEASE_NAME>-airflow-result-backend`` |
``.Values.data.resultBackendSecretName`` | |
``AIRFLOW__CELERY__CELERY_RESULT_BACKEND`` |
+| ``<RELEASE_NAME>-result-backend`` |
``.Values.data.resultBackendSecretName`` | |
``AIRFLOW__CELERY__CELERY_RESULT_BACKEND`` |
Review Comment:
```suggestion
| ``<RELEASE_NAME>-result-backend`` |
``.Values.data.resultBackendSecretName`` | |
``AIRFLOW__CELERY__CELERY_RESULT_BACKEND`` |
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
