jedcunningham commented on code in PR #22676:
URL: https://github.com/apache/airflow/pull/22676#discussion_r843386018
##########
chart/UPDATING.rst:
##########
@@ -43,6 +43,9 @@ Default Airflow image is updated to ``2.2.5``
The default Airflow image that is used with the Chart is now ``2.2.5``,
previously it was ``2.2.4``.
+Resources naming has been updated to support ``nameOverride`` and
``fullnameOverride``. The default name is now derived from .Release.Name and
chart name.
Review Comment:
```suggestion
Support for ``nameOverride`` and ``fullnameOverride``
"""""""""""""""""""""""""""""""""""""""""""""""""""""
Resources naming has been updated to support ``nameOverride`` and
``fullnameOverride``. The default name is now derived from .Release.Name and
chart name.
```
##########
docs/helm-chart/production-guide.rst:
##########
@@ -452,17 +452,17 @@ Here is the full list of secrets that can be disabled and
replaced by ``_CMD`` a
+-------------------------------------------------------+------------------------------------------+--------------------------------------------------+
| Default secret name if secret name not specified | Use a different
Kubernetes Secret | Airflow Environment Variable |
+=======================================================+==========================================+==================================================+
-| ``<RELEASE_NAME>-airflow-metadata`` |
``.Values.data.metadataSecretName`` | | ``AIRFLOW_CONN_AIRFLOW_DB``
|
+| ``<RELEASE_NAME>-airflow-metadata`` |
``.Values.data.metadataSecretName`` | | ``AIRFLOW_CONN_AIRFLOW_DB``
|
| |
| | ``AIRFLOW__CORE__SQL_ALCHEMY_CONN`` |
+-------------------------------------------------------+------------------------------------------+--------------------------------------------------+
| ``<RELEASE_NAME>-fernet-key`` |
``.Values.fernetKeySecretName`` | ``AIRFLOW__CORE__FERNET_KEY``
|
+-------------------------------------------------------+------------------------------------------+--------------------------------------------------+
| ``<RELEASE_NAME>-webserver-secret-key`` |
``.Values.webserverSecretKeySecretName`` | ``AIRFLOW__WEBSERVER__SECRET_KEY``
|
+-------------------------------------------------------+------------------------------------------+--------------------------------------------------+
-| ``<RELEASE_NAME>-airflow-result-backend`` |
``.Values.data.resultBackendSecretName`` | |
``AIRFLOW__CELERY__CELERY_RESULT_BACKEND`` |
+| ``<RELEASE_NAME>-airflow-result-backend`` |
``.Values.data.resultBackendSecretName`` | |
``AIRFLOW__CELERY__CELERY_RESULT_BACKEND`` |
Review Comment:
```suggestion
| ``<RELEASE_NAME>-airflow-result-backend`` |
``.Values.data.resultBackendSecretName`` | |
``AIRFLOW__CELERY__CELERY_RESULT_BACKEND`` |
```
Oops, now we have extra spaces :)
##########
docs/helm-chart/production-guide.rst:
##########
@@ -452,17 +452,17 @@ Here is the full list of secrets that can be disabled and
replaced by ``_CMD`` a
+-------------------------------------------------------+------------------------------------------+--------------------------------------------------+
| Default secret name if secret name not specified | Use a different
Kubernetes Secret | Airflow Environment Variable |
+=======================================================+==========================================+==================================================+
-| ``<RELEASE_NAME>-airflow-metadata`` |
``.Values.data.metadataSecretName`` | | ``AIRFLOW_CONN_AIRFLOW_DB``
|
+| ``<RELEASE_NAME>-airflow-metadata`` |
``.Values.data.metadataSecretName`` | | ``AIRFLOW_CONN_AIRFLOW_DB``
|
Review Comment:
```suggestion
| ``<RELEASE_NAME>-airflow-metadata`` |
``.Values.data.metadataSecretName`` | | ``AIRFLOW_CONN_AIRFLOW_DB``
|
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
