eladkal commented on code in PR #22758:
URL: https://github.com/apache/airflow/pull/22758#discussion_r851990135
##########
airflow/providers/amazon/aws/operators/s3.py:
##########
@@ -318,6 +318,94 @@ def execute(self, context: 'Context'):
)
+class S3CreateObjectOperator(BaseOperator):
+ """
+ Creates a new object from a given string or bytes.
Review Comment:
> Maybe we can flip the question around and here what concerns, risks,
oversights and pitfalls you see over including this operator? Thanks!
None.
I said that my concern is the use case of how this operator is to be used.
I'm concerned that users will use this differently than what intended - and we
actually discovered during this discussion that the original intention was for
`HttpToS3Operator`. The process we did here is not something users are
likely to do. I am more worried that we are serving users a way to a bad
practice even if we don't mean that.
I'd be more comfortable with adding example dag which emphasise how the
operator is expected to be used (e.g an actual example that shows the data
expected to be passed is metadata).
That said - I am not going to block this operator. We were just having
discussion.
If you still think differently i'd be happy to resolve this discussion and
move to the code review part.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
