eladkal commented on code in PR #22758:
URL: https://github.com/apache/airflow/pull/22758#discussion_r845540146
##########
airflow/providers/amazon/aws/operators/s3.py:
##########
@@ -318,6 +318,94 @@ def execute(self, context: 'Context'):
)
+class S3CreateObjectOperator(BaseOperator):
+ """
+ Creates a new object from a given string or bytes.
Review Comment:
But for that to work it means that by some other way someone stored data in
Xcom and then you want to create S3 object from the data stored in xcom.
This is why I asked to see an actual DAG example using this operator as part
of a complete workflow.
Lets see what other thinks...
##########
airflow/providers/amazon/aws/operators/s3.py:
##########
@@ -318,6 +318,94 @@ def execute(self, context: 'Context'):
)
+class S3CreateObjectOperator(BaseOperator):
+ """
+ Creates a new object from a given string or bytes.
Review Comment:
But for that to work it means that by some other way someone stored data in
Xcom and then you want to create S3 object from the data stored in xcom.
This is why I asked to see an actual DAG example using this operator as part
of a complete workflow.
Lets see what other think...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
