josh-fell commented on code in PR #23070:
URL: https://github.com/apache/airflow/pull/23070#discussion_r853314329
##########
airflow/providers/google/cloud/operators/vertex_ai/endpoint_service.py:
##########
@@ -81,6 +81,7 @@ def __init__(
region: str,
project_id: str,
endpoint: Union[Endpoint, Dict],
+ endpoint_id: Optional[str] = None,
Review Comment:
Do you think this new parameter should be added to `template_fields` for the
operator? I'm not sure if this would be useful or what kinds of values are
typical for `endpoint_id`. Just sharing the idea.
##########
airflow/providers/google/cloud/operators/vertex_ai/endpoint_service.py:
##########
@@ -81,6 +81,7 @@ def __init__(
region: str,
project_id: str,
endpoint: Union[Endpoint, Dict],
+ endpoint_id: Optional[str] = None,
Review Comment:
Also, this new parameter should be added to the operator's docstring so it
can be included in the Python API docs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
