mai-nakagawa commented on code in PR #23070:
URL: https://github.com/apache/airflow/pull/23070#discussion_r853647862
##########
airflow/providers/google/cloud/operators/vertex_ai/endpoint_service.py:
##########
@@ -81,6 +81,7 @@ def __init__(
region: str,
project_id: str,
endpoint: Union[Endpoint, Dict],
+ endpoint_id: Optional[str] = None,
Review Comment:
> Do you think this new parameter should be added to `template_fields` for
the operator? I'm not sure if this would be useful or what kinds of values are
typical for `endpoint_id`. Just sharing the idea.
Thanks for your suggestion! I don't think `endpoint_id` should be added to
`template_fields`. I think the optional param `endpoint_id` is used only when
users would like to create a Vertex Endpoint with a specified ID. I don't
imagine an use case to specify the ID dynamically 😃
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
