bperson commented on code in PR #23442:
URL: https://github.com/apache/airflow/pull/23442#discussion_r863603574
##########
airflow/providers/opsgenie/hooks/opsgenie.py:
##########
@@ -126,7 +126,7 @@ def close_alert(
identifier=identifier,
identifier_type=identifier_type,
close_alert_payload=close_alert_payload,
- kwargs=kwargs,
+ **kwargs,
Review Comment:
Right now, `OpsgenieCloseAlertOperator.execute` sends `close_alert_kwargs`
as a normal param called `kwargs` ( which is not great, but should work ).
If we want to update that, this needs to be updated as well:
https://github.com/apache/airflow/blob/22b49d334ef0008be7bd3d8481b55b8ab5d71c80/airflow/providers/opsgenie/hooks/opsgenie.py#L106
So should I properly `kwarg`-ify the whole chain? including
`OpsgenieAlertHook.close_alert`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
