eladkal commented on code in PR #23442:
URL: https://github.com/apache/airflow/pull/23442#discussion_r863609895
##########
airflow/providers/opsgenie/hooks/opsgenie.py:
##########
@@ -126,7 +126,7 @@ def close_alert(
identifier=identifier,
identifier_type=identifier_type,
close_alert_payload=close_alert_payload,
- kwargs=kwargs,
+ **kwargs,
Review Comment:
ah right. I think it's fine because it's kwargs for `close_alert` so it's
very self explanatory.
OK I remembered what I tried to do. the goal was to support `call_api` params
https://github.com/opsgenie/opsgenie-python-sdk/blob/0d20d2314522fc0fd8ca5f0faa16f7c96387e123/opsgenie_sdk/api_client.py#L380-L386
like `async_req`
https://github.com/apache/airflow/blob/22b49d334ef0008be7bd3d8481b55b8ab5d71c80/tests/providers/opsgenie/hooks/test_opsgenie.py#L129
It could be that the implementation is bugged. can you look into it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
