ephraimbuddy commented on code in PR #23797:
URL: https://github.com/apache/airflow/pull/23797#discussion_r877213188


##########
airflow/utils/state.py:
##########
@@ -192,7 +193,7 @@ def color_fg(cls, state):
     """
 
     success_states: FrozenSet[TaskInstanceState] = frozenset(
-        [TaskInstanceState.SUCCESS, TaskInstanceState.SKIPPED]
+        [TaskInstanceState.SUCCESS, TaskInstanceState.SKIPPED, 
TaskInstanceState.REMOVED]

Review Comment:
   It's not detected as deadlock but it keeps on trying to restore it and the 
dagrun would be stuck in running state. In dagrun.update_states, even if the 
task instance state is in finished states, they still need to be in either 
failed states or success states to determine the overall state of the dagrun



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to