ashb commented on code in PR #23797:
URL: https://github.com/apache/airflow/pull/23797#discussion_r877216065
##########
airflow/utils/state.py:
##########
@@ -192,7 +193,7 @@ def color_fg(cls, state):
"""
success_states: FrozenSet[TaskInstanceState] = frozenset(
- [TaskInstanceState.SUCCESS, TaskInstanceState.SKIPPED]
+ [TaskInstanceState.SUCCESS, TaskInstanceState.SKIPPED,
TaskInstanceState.REMOVED]
Review Comment:
I think rather than adding REMOVED here as a success we should change this
in DagRun
```diff
leaf_task_ids = {t.task_id for t in dag.leaves}
- leaf_tis = [ti for ti in tis if ti.task_id in leaf_task_ids]
+ leaf_tis = [ti for ti in tis if ti.task_id in leaf_task_ids if
ti.state != TaskInstanceState.REMOVED]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
