ashb commented on a change in pull request #5302: [AIRFLOW-4374] Make
enum-like-classes inherit from enum
URL: https://github.com/apache/airflow/pull/5302#discussion_r292382680
##########
File path: tests/utils/test_trigger_rule.py
##########
@@ -24,12 +24,12 @@
class TestTriggerRule(unittest.TestCase):
def test_valid_trigger_rules(self):
- self.assertTrue(TriggerRule.is_valid(TriggerRule.ALL_SUCCESS))
- self.assertTrue(TriggerRule.is_valid(TriggerRule.ALL_FAILED))
- self.assertTrue(TriggerRule.is_valid(TriggerRule.ALL_DONE))
- self.assertTrue(TriggerRule.is_valid(TriggerRule.ONE_SUCCESS))
- self.assertTrue(TriggerRule.is_valid(TriggerRule.ONE_FAILED))
- self.assertTrue(TriggerRule.is_valid(TriggerRule.NONE_FAILED))
- self.assertTrue(TriggerRule.is_valid(TriggerRule.NONE_SKIPPED))
- self.assertTrue(TriggerRule.is_valid(TriggerRule.DUMMY))
+ self.assertTrue(TriggerRule.ALL_SUCCESS in TriggerRule)
+ self.assertTrue(TriggerRule.ALL_FAILED in TriggerRule)
+ self.assertTrue(TriggerRule.ALL_DONE in TriggerRule)
+ self.assertTrue(TriggerRule.ONE_SUCCESS in TriggerRule)
+ self.assertTrue(TriggerRule.ONE_FAILED in TriggerRule)
+ self.assertTrue(TriggerRule.NONE_FAILED in TriggerRule)
+ self.assertTrue(TriggerRule.NONE_SKIPPED in TriggerRule)
+ self.assertTrue(TriggerRule.DUMMY in TriggerRule)
Review comment:
These tests seem unnecessary now - it seems impossible they would ever fail.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
