ashb commented on a change in pull request #5302: [AIRFLOW-4374] Make enum-like-classes inherit from enum URL: https://github.com/apache/airflow/pull/5302#discussion_r292382335
########## File path: docs/concepts.rst ########## @@ -737,28 +737,28 @@ dependency settings. All operators have a ``trigger_rule`` argument which defines the rule by which the generated task get triggered. The default value for ``trigger_rule`` is -``all_success`` and can be defined as "trigger this task when all directly +``TriggerRule.ALL_SUCCESS`` and can be defined as "trigger this task when all directly upstream tasks have succeeded". All other rules described here are based on direct parent tasks and are values that can be passed to any operator while creating tasks: Review comment: We probably need to mention in this doc that these aren't strings but constants/enums from module X. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
