potiuk commented on code in PR #23715:
URL: https://github.com/apache/airflow/pull/23715#discussion_r889745636
##########
dev/breeze/src/airflow_breeze/commands/testing_commands.py:
##########
@@ -112,6 +117,49 @@ def docker_compose_tests(
sys.exit(return_code)
+def run_tests(
+ shell_params: ShellParams, dry_run: bool, verbose: bool,
extra_pytest_args: Tuple
+) -> Tuple[int, str]:
+ env_variables = get_env_variables_for_docker_commands(shell_params)
+ perform_environment_checks(verbose=verbose)
+ cmd = ['docker-compose', 'run', '--service-ports', '--rm', 'airflow']
+ cmd.extend(list(extra_pytest_args))
+ test_result = run_command(
+ cmd,
+ verbose=verbose,
+ dry_run=dry_run,
+ env=env_variables,
+ )
+ return (
+ test_result.returncode,
+ f"Running tests for Python {shell_params.python}",
+ )
+
+
+def run_tests_in_parallel(
+ shell_params_list: List[ShellParams],
+ python_version_list: List[str],
+ parallelism: int,
+ dry_run: bool,
+ verbose: bool,
+):
+ """Run tests in parallel"""
+ get_console().print(
+ f"\n[info]Running tests with parallelism = {parallelism} "
+ f"for the python versions: {python_version_list}[/]"
+ )
+ pool = mp.Pool(parallelism)
Review Comment:
Airflow has 600+dependencies. Adding one more seems like not much but we
should avoid it if possible. Stdlib's Pool is good enough for us.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
