denimalpaca commented on code in PR #23915:
URL: https://github.com/apache/airflow/pull/23915#discussion_r890339418
##########
tests/operators/test_sql.py:
##########
@@ -385,6 +387,82 @@ def test_fail_min_sql_max_value(self, mock_get_db_hook):
operator.execute()
+class TestColumnCheckOperator(unittest.TestCase):
+
+ valid_column_mapping = {
+ "X": {
+ "null_check": {"equal_to": 0},
+ "distinct_check": {"equal_to": 10, "tolerance": 0.1},
+ "unique_check": {"geq_than": 10},
+ "min": {"leq_than": 1},
+ "max": {"less_than": 20, "greater_than": 10},
+ }
+ }
+
+ invalid_column_mapping = {"Y": {"invalid_check_name": {"expectation": 5}}}
+
+ def _construct_operator(self, column_mapping):
+ return SQLColumnCheckOperator(task_id="test_task", table="test_table",
column_mapping=column_mapping)
+
+ @mock.patch.object(SQLColumnCheckOperator, "get_db_hook")
+ def test_check_not_in_column_checks(self, mock_get_db_hook):
+ with pytest.raises(AirflowException, match="Invalid column check:
invalid_check_name."):
+ self._construct_operator(self.invalid_column_mapping)
+
+ @mock.patch.object(SQLColumnCheckOperator, "get_db_hook")
+ def test_pass_all_checks_exact_check(self, mock_get_db_hook):
+ mock_hook = mock.Mock()
+ mock_hook.get_first.return_value = (0, 10, 10, 1, 19)
+ mock_get_db_hook.return_value = mock_hook
+ operator = self._construct_operator(self.valid_column_mapping)
+ operator.execute()
+
+ @mock.patch.object(SQLColumnCheckOperator, "get_db_hook")
+ def test_pass_all_checks_inexact_check(self, mock_get_db_hook):
+ mock_hook = mock.Mock()
+ mock_hook.get_first.return_value = (0, 9, 12, 0, 15)
+ mock_get_db_hook.return_value = mock_hook
+ operator = self._construct_operator(self.valid_column_mapping)
+ operator.execute()
Review Comment:
It's implicitly `assert mock_hook.get_first.return_value[i] ==
self.valid_column_mapping[condition_i]`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
